-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discord AHelp Replies #45
Open
sleepyyapril
wants to merge
7
commits into
Goob-Station:master
Choose a base branch
from
sleepyyapril:discord-ahelp-replies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Discord AHelp Replies #45
sleepyyapril
wants to merge
7
commits into
Goob-Station:master
from
sleepyyapril:discord-ahelp-replies
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Whatstone <[email protected]> Co-authored-by: Whatstone <[email protected]> Co-authored-by: Myzumi <[email protected]> Co-authored-by: Aiden <[email protected]>
Co-authored-by: Aiden <[email protected]>
I would honestly just wait until my Upstream discord integration is merged. From there I plan on refactoring the bwoinksystem.cs to then integrate more nicely. |
Doesnt hurt to use this as a stopgap until then |
Simyon264
requested changes
Dec 21, 2024
Simyon264
reviewed
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This ports new-frontiers-14/frontier-station-14#2283 which allows admins to respond to AHelps while on discord.
Why / Balance
Not needing to be in-game to handle ahelps is a benefit for all admins.
Technical details
This PR requires:
This PR changes the way the BwoinkSystem works to allow for custom URLs instead of just an id and a token for webhooks, as well as adding an admin API HTTP POST method under
/admin/actions/send_bwoink
.Media
Requirements
Breaking changes
None