Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord AHelp Replies #45

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sleepyyapril
Copy link
Contributor

@sleepyyapril sleepyyapril commented Dec 17, 2024

About the PR

This ports new-frontiers-14/frontier-station-14#2283 which allows admins to respond to AHelps while on discord.

Why / Balance

Not needing to be in-game to handle ahelps is a benefit for all admins.

Technical details

This PR requires:

  1. Something that can handle the discord side, see original PR for details. You can also use my RedBot cog, if you use RedBot.
  2. A set admin.api_token CVar value to use on the discord side.
  3. CVar status.enabled being true

This PR changes the way the BwoinkSystem works to allow for custom URLs instead of just an id and a token for webhooks, as well as adding an admin API HTTP POST method under /admin/actions/send_bwoink.

Media

image
image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

None

sleepyyapril and others added 2 commits December 17, 2024 14:47
Co-authored-by: Whatstone <[email protected]>
Co-authored-by: Whatstone <[email protected]>
Co-authored-by: Myzumi <[email protected]>
Co-authored-by: Aiden <[email protected]>
@Simyon264
Copy link
Member

I would honestly just wait until my Upstream discord integration is merged. From there I plan on refactoring the bwoinksystem.cs to then integrate more nicely.

@Aidenkrz
Copy link
Collaborator

I would honestly just wait until my Upstream discord integration is merged. From there I plan on refactoring the bwoinksystem.cs to then integrate more nicely.

Doesnt hurt to use this as a stopgap until then

Content.Server/Administration/Systems/BwoinkSystem.cs Outdated Show resolved Hide resolved
Content.Server/Administration/Systems/BwoinkSystem.cs Outdated Show resolved Hide resolved
Content.Server/Administration/Systems/BwoinkSystem.cs Outdated Show resolved Hide resolved
Content.Server/Administration/Systems/BwoinkSystem.cs Outdated Show resolved Hide resolved
Content.Server/Administration/Systems/BwoinkSystem.cs Outdated Show resolved Hide resolved
Content.Server/Administration/Systems/BwoinkSystem.cs Outdated Show resolved Hide resolved
Content.Server/Administration/Systems/BwoinkSystem.cs Outdated Show resolved Hide resolved
Content.Shared/CCVar/CCVars.Admin.Ahelp.cs Outdated Show resolved Hide resolved
Content.Server/Administration/Systems/BwoinkSystem.cs Outdated Show resolved Hide resolved
Content.Server/Discord/WebhookPayload.cs Outdated Show resolved Hide resolved
This reverts commit 891fc0d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants